Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for job actions #1644

Open
wants to merge 10 commits into
base: release-jobs
Choose a base branch
from
Open

Add tests for job actions #1644

wants to merge 10 commits into from

Conversation

despadam
Copy link

@despadam despadam commented Jan 21, 2025 •
edited
Loading

Description

Add unit tests for the job actions.

Motivation

#1435

Changes:

  • Email:
    • test templating and sending, using src/common/email-templates/job-template.spec.html
  • RabbitMQ:
    • test connecting and sending message to queue
    • added necessary configuration
  • Url:
    • test GET method

@despadam despadam requested a review from sbliven January 22, 2025 13:53
@despadam despadam requested a review from sofyalaski January 23, 2025 15:57
sofyalaski
sofyalaski approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@sofyalaski sofyalaski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofyalaski sofyalaski sofyalaski approved these changes

@sbliven sbliven Awaiting requested review from sbliven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@despadam @sofyalaski